samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shanthoosh <...@git.apache.org>
Subject [GitHub] samza pull request #249: Fix log messages from StreamProcessor(onJobModelExp...
Date Tue, 25 Jul 2017 17:29:55 GMT
GitHub user shanthoosh opened a pull request:

    https://github.com/apache/samza/pull/249

    Fix log messages from StreamProcessor(onJobModelExpired event).

    Log messages published in onJobModelExpired event have `processorId` as null. `processorId`
is cached as final var in jobCoordinatorListener method. JLS for final fields/variables states
that they're initialized before the constructor. This sets local final variable copy as null(since
it relies upon value of instance variable to be set in constructor).
    Changes
    * Use processorId directly in `createCoordinatorListener` method.
    * Remove StreamProcessor.toString since it has no usages.
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shanthoosh/samza fix_logging_in_stream_processor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/249.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #249
    
----
commit 2192a9dc3876e3e44b18be21800f51d76d5db3cf
Author: Shanthoosh Venkataraman <svenkataraman@linkedin.com>
Date:   2017-07-25T17:22:58Z

    Fix log messages from StreamProcessor(onJobModelExpired event).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message