samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fredji97 <...@git.apache.org>
Subject [GitHub] samza pull request #398: SAMZA-1542 refactor config classes in samza-core ja...
Date Wed, 03 Jan 2018 00:54:13 GMT
GitHub user fredji97 opened a pull request:

    https://github.com/apache/samza/pull/398

    SAMZA-1542 refactor config classes in samza-core java to hide non-necessary interfaces

    With previous inheritance, it exposed everything from Config class, which is a bad practice
and is error prone. We are refactoring it to use composition over inheritance make it more
robust. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fredji97/samza samzaCoreJavaConfig

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/398.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #398
    
----
commit 34dd7f40f044b7c219e402dbc4575579d0c42643
Author: Fred Ji <haifeng.ji@...>
Date:   2018-01-03T00:51:47Z

    SAMZA-1542 refactor config classes in samza-core java to hide non-necessary interfaces

----


---

Mime
View raw message