samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cameronlee314 <...@git.apache.org>
Subject [GitHub] samza pull request #644: SAMZA-1880: Rename non-metrics classes which use Ti...
Date Tue, 18 Sep 2018 00:52:47 GMT
GitHub user cameronlee314 opened a pull request:

    https://github.com/apache/samza/pull/644

    SAMZA-1880: Rename non-metrics classes which use Timer in their name

    Summary of API changes:
    1. TimerRegistry -> KeyScheduler; _register_ -> _schedule_
    2. TimerFunction -> SchedulingFunction; _registerTimer_ -> _schedulingInit_, _onTimer_
-> _executeForKey_
    3. TimerCallback -> SchedulingCallback _onTimer_ -> _execute_
    4. TaskContext: _registerTimer_ -> _scheduleCallback_, _deleteTimer_ -> _deleteScheduledCallback_
    
    Only terminology changes are intended (e.g. classes, var names, logs). No functionality
change is intended.
    An upcoming PR will further update TaskContext and the access to the scheduling logic.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cameronlee314/samza rename_timer

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/644.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #644
    
----
commit 67c3608d00fb70aa7124c0c671ba281e4dbc5a57
Author: Cameron Lee <calee@...>
Date:   2018-09-18T00:25:18Z

    SAMZA-1880: Rename non-metrics classes which use Timer in their name

commit db4fad6debe101f5103537f7c942011505ea2829
Author: Cameron Lee <calee@...>
Date:   2018-09-18T00:46:18Z

    minor style check update

----


---

Mime
View raw message