samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] srinipunuru commented on a change in pull request #911: Support for types in Samza SQL UDF
Date Mon, 11 Feb 2019 17:31:58 GMT
srinipunuru commented on a change in pull request #911: Support for types in Samza SQL UDF
URL: https://github.com/apache/samza/pull/911#discussion_r255613496
 
 

 ##########
 File path: samza-sql/src/main/java/org/apache/samza/sql/data/SamzaSqlExecutionContext.java
 ##########
 @@ -38,7 +40,10 @@
    * The variables that are shared among all cloned instance of {@link SamzaSqlExecutionContext}
    */
   private final SamzaSqlApplicationConfig sqlConfig;
-  private final Map<String, UdfMetadata> udfMetadata;
+
+  // Maps the UDF name to list of all UDF methods associated with the name.
+  // Since we support polymorphism there can multiple udfMetadata associated with the single
name.
 
 Review comment:
   There was already a testcase (testEndToEndStreamTableTableJoinWithPrimaryKeys) which covers
this, because we are passing both object as we all as an integer to the MyTest. I just added
another test targeting this specifically.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message