samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] srinipunuru commented on a change in pull request #911: Support for types in Samza SQL UDF
Date Mon, 11 Feb 2019 17:34:31 GMT
srinipunuru commented on a change in pull request #911: Support for types in Samza SQL UDF
URL: https://github.com/apache/samza/pull/911#discussion_r255614560
 
 

 ##########
 File path: samza-sql/src/main/java/org/apache/samza/sql/fn/GetSqlFieldUdf.java
 ##########
 @@ -51,22 +52,21 @@
  *           - sessionKey (Scalar)
  *
  */
-@SamzaSqlUdf(name = "GetSqlField")
+@SamzaSqlUdf(name = "GetSqlField", description = "Get an element from complex Sql field.")
 
 Review comment:
   Function overloads will not work if only the return types change. They work if the arguments
are different. If a UDF has to return a type that can be different, Then it has to return
an object in which case the return type will be "ANY". Does it answer your question? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message