samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] weiqingy commented on a change in pull request #911: Support for types in Samza SQL UDF
Date Mon, 11 Feb 2019 19:03:12 GMT
weiqingy commented on a change in pull request #911: Support for types in Samza SQL UDF
URL: https://github.com/apache/samza/pull/911#discussion_r255648188
 
 

 ##########
 File path: samza-api/src/main/java/org/apache/samza/sql/udfs/ScalarUdf.java
 ##########
 @@ -24,7 +24,7 @@
 
 /**
  * The base class for the Scalar UDFs. All the scalar UDF classes needs to extend this and
implement a method named
- * "execute". The number and type of arguments for the execute method in the UDF class should
match the number and type of fields
+ * "execute". The number and type of arguments for the method annotated with {@link SamzaSqlUdfMethod}
in the UDF class should match the number and type of fields
 
 Review comment:
   nit: shall we also remove the "execute" from the first sentence?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message