samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] atoomula commented on a change in pull request #911: Support for types in Samza SQL UDF
Date Mon, 11 Feb 2019 19:06:53 GMT
atoomula commented on a change in pull request #911: Support for types in Samza SQL UDF
URL: https://github.com/apache/samza/pull/911#discussion_r255648927
 
 

 ##########
 File path: samza-sql/src/main/java/org/apache/samza/sql/fn/GetSqlFieldUdf.java
 ##########
 @@ -51,22 +52,21 @@
  *           - sessionKey (Scalar)
  *
  */
-@SamzaSqlUdf(name = "GetSqlField")
+@SamzaSqlUdf(name = "GetSqlField", description = "Get an element from complex Sql field.")
 
 Review comment:
   Sure. Could we change the description to reflect that it returns a string. May be: "Get
an element as a String from Complex Sql field." ? As a separate effort, we will have to add
another such Udf that returns ANY.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message