samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover
Date Tue, 12 Feb 2019 18:41:32 GMT
vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware
container allocation, and active container failover
URL: https://github.com/apache/samza/pull/903#discussion_r255769800
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/clustermanager/SamzaApplicationState.java
 ##########
 @@ -78,9 +79,10 @@
   public final AtomicInteger releasedContainers = new AtomicInteger(0);
 
   /**
-   * ContainerStatus of failed containers.
+   * ContainerStatuses of failed containers indexed by samzaContainerId.
+   * Written by the AMRMCallbackThread, read by the ContainerAllocator thread when performing
active-standby container failover.
    */
-  public final ConcurrentMap<String, SamzaResourceStatus> failedContainersStatus =
new ConcurrentHashMap<String, SamzaResourceStatus>();
+  public final ConcurrentMap<String, LinkedList<SamzaResourceStatus>> failedContainersStatus
= new ConcurrentHashMap<String, LinkedList<SamzaResourceStatus>>();
 
 Review comment:
   Why do you need this - ConcurrentMap<logicalId, List<ResourceStatus>>.. It
seems like the usage is to determine the physical-id corresponding to a given logical-id.
If so, the existing data-structures should be sufficient?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message