samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover
Date Tue, 12 Feb 2019 18:41:32 GMT
vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware
container allocation, and active container failover
URL: https://github.com/apache/samza/pull/903#discussion_r255766345
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java
 ##########
 @@ -195,14 +195,25 @@ protected final SamzaResourceRequest peekPendingRequest() {
     return resourceRequestState.peekPendingRequest();
   }
 
+  /**
+   *  Method to handle re-requesting of resource for a given container, in cases where
+   *  a prior resource request for the container, expired or the launch failed (due to a
startup-fail, or
+   *  standby constraints not being met).
+   * @param containerID Identifier of the container that will be run when a resource is allocated
+   *
+   */
+  public void requestResourceDueToLaunchFailOrExpiredRequest(String containerID) {
 
 Review comment:
   remove this method since it simply delegates to requestResource(containerID, ANY_HOST)..
Instead can invoke requestResource(containerID, ANY_HOST) at the call-site directly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message