samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover
Date Tue, 12 Feb 2019 18:41:32 GMT
vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware
container allocation, and active container failover
URL: https://github.com/apache/samza/pull/903#discussion_r256084515
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/clustermanager/SamzaApplicationState.java
 ##########
 @@ -141,6 +143,36 @@
    */
   public final AtomicInteger redundantNotifications = new AtomicInteger(0);
 
+  /**
+   * Number of container allocations that proceeded because they met standby container constraints.
+   */
+  public final AtomicInteger successfulStandbyAllocations = new AtomicInteger(0);
+
+  /**
+   * Number of container allocations that were dis-allowed because they
+   * did not meet standby container constraints.
+   */
+  public final AtomicInteger failedStandbyAllocations = new AtomicInteger(0);
+
+  /**
+   * Number of active container failovers initiated in which a standby container was found.
+   * If two standby containers had to selected for one failing active, it counts as two.
+   */
+  public final AtomicInteger failoversToStandby = new AtomicInteger(0);
+
+  /**
+   * Number of active container failovers initiated in which a standby container was NOT
found.
+  */
+  public final AtomicInteger failoversToAnyHost = new AtomicInteger(0);
+
+  /**
+   * Number of stops of standby containers that completed.
+   */
+  public final AtomicInteger standbyStopsComplete = new AtomicInteger(0);
+
+  // Map of active containers that are in failover, indexed by the active container's resourceID
(at the time of failure)
+  public final ConcurrentMap<String, ContainerFailoverState> failovers = new ConcurrentHashMap<String,
ContainerFailoverState>(0);
 
 Review comment:
   move state that pertains to failover to a new class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message