samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover
Date Tue, 12 Feb 2019 18:41:33 GMT
vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware
container allocation, and active container failover
URL: https://github.com/apache/samza/pull/903#discussion_r256070415
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/clustermanager/HostAwareContainerAllocator.java
 ##########
 @@ -45,10 +53,22 @@
    */
   private final int requestTimeout;
 
+  // Map of activeContainerIDs to its corresponding standby containers, and standbyContainerIDs
to its corresponding
+  // active container and other corresponding standbyContainers
+  private final Map<String, List<String>> standbyContainerConstraints = new HashMap<>();
 
 Review comment:
   This map is un-necessary because it appears to be conflating too many roles..
   
   You can simplify / consolidate state in a single class with the following APIs:
   - List\<SamzaResource\> getStandbyContainers(activeResourceId)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message