samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] atoomula commented on a change in pull request #916: End to end test case for union type with subRecord
Date Wed, 13 Feb 2019 15:38:37 GMT
atoomula commented on a change in pull request #916: End to end test case for union type with
subRecord
URL: https://github.com/apache/samza/pull/916#discussion_r256434838
 
 

 ##########
 File path: samza-sql/src/main/java/org/apache/samza/sql/avro/AvroRelConverter.java
 ##########
 @@ -207,7 +207,11 @@ static public Object convertToAvroObject(Object relObj, Schema schema)
{
             .collect(Collectors.toMap(Map.Entry::getKey, e -> convertToAvroObject(e.getValue(),
                 getNonNullUnionSchema(schema).getValueType())));
       case UNION:
-        return convertToAvroObject(relObj, getNonNullUnionSchema(schema));
+        for (Schema unionSchema : schema.getTypes()) {
 
 Review comment:
   We have an AvroRelConverter version in Linkedin. We will have to merge these two and get
rid of the Linkedin one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message