samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.
Date Wed, 20 Feb 2019 01:03:47 GMT
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor
for the KafkaSystemConsumer.
URL: https://github.com/apache/samza/pull/918#discussion_r258281900
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/system/SystemAdmins.java
 ##########
 @@ -38,6 +38,10 @@ public SystemAdmins(Config config) {
     this.systemAdminMap = systemConfig.getSystemAdmins();
   }
 
+  public SystemAdmins(Map<String, SystemAdmin> systemAdminMap) {
 
 Review comment:
   Is this just for tests? Is it possible to avoid doing this? Could you make a mock `SystemAdmins`
instead? Maybe just always have it return a mock `SystemAdmin`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message