samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrey Paykin <andreypay...@gmail.com>
Subject code cleanups
Date Mon, 04 Feb 2019 12:54:21 GMT
Hello,

I am newcomer and getting familiar with codebase. I noticed many IDE
warnings and obsolete things (such as parameters declaration instead of
diamond operator, redundant modifiers, etc.)
So I wanted to make a PR for code cleanup, but there are few questions:
1. Is this idea make sense (code cleanup)
2. Do I need JIRA ticket(s)? May be there is some example ticket or
additional requirements?
3. If answer for 2 is yes, how should I organize it? If all cleanups are
submitted in one PR it can be difficult to review. Or cleanups can be
submitted for each module separately with many PRs for each ticket, it
leads to many same tickets. What is better way?

Best regards,
Andrei

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message