sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SENTRY-38) Cleanup Roles/DBRoles
Date Wed, 09 Oct 2013 21:04:41 GMT

    [ https://issues.apache.org/jira/browse/SENTRY-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790852#comment-13790852
] 

Brock Noland commented on SENTRY-38:
------------------------------------

bq. those lines were copy pasted, so the old version had issues too. Good to fix it up here
though

Ahh it was probably my error then. Thanks for fixing.

> Cleanup Roles/DBRoles
> ---------------------
>
>                 Key: SENTRY-38
>                 URL: https://issues.apache.org/jira/browse/SENTRY-38
>             Project: Sentry
>          Issue Type: Sub-task
>    Affects Versions: 1.3.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>             Fix For: 1.3.0
>
>         Attachments: SENTRY-38.patch, SENTRY-38v2.patch
>
>
> The Roles interface now is kind of messy, because it has a DB-specific function:
> {code}
> public ImmutableSet<String> getRoles(@Nullable String database, String group, Boolean
isURI);
> {code}
> It makes more sense to just have a Roles class that store roles, and have the PolicyEngine
do the service-specific calculations.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message