sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasad Mujumdar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SENTRY-195) Sentry schema tool can't process comments inside statement
Date Mon, 12 May 2014 01:36:14 GMT

    [ https://issues.apache.org/jira/browse/SENTRY-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994744#comment-13994744
] 

Prasad Mujumdar commented on SENTRY-195:
----------------------------------------

+1
Looks fine to me. Thanks for catching the issue and the fix!

> Sentry schema tool can't process comments inside statement
> ----------------------------------------------------------
>
>                 Key: SENTRY-195
>                 URL: https://issues.apache.org/jira/browse/SENTRY-195
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.4.0
>
>         Attachments: SENTRY-195.patch
>
>
> While reviewing SENTRY-193, I've noticed that our schema scripts contains comments in
the middle of the statement that our schema tool is not able to correctly process. Considering
that the scripts are machine oriented, I think that it's safe to drop those comments.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message