sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sravya Tirukkovalur (JIRA)" <>
Subject [jira] [Commented] (SENTRY-305) SHOW CURRENT ROLES shouldn't require admin privileges
Date Wed, 18 Jun 2014 21:44:24 GMT


Sravya Tirukkovalur commented on SENTRY-305:

[~prasadm], thanks for the patch. It mostly looks good to me. Although I see two test failures:

Results :
Failed tests: 
  TestDatabaseProvider.testSetRole:1571 User admin1 shouldn't be able to set testRole2
Tests in error: 
  TestDatabaseProvider.testShowAllCurrentRoles:1546 ยป SQL Error while processing...

Can you take a look and update the patch please?

> SHOW CURRENT ROLES shouldn't require admin privileges
> -----------------------------------------------------
>                 Key: SENTRY-305
>                 URL:
>             Project: Sentry
>          Issue Type: Bug
>            Reporter: Prasad Mujumdar
>            Assignee: Prasad Mujumdar
>         Attachments: SENTRY-305.4.patch, SENTRY-305.6.patch
> SHOW CURRENT ROLES shouldn't require admin privileges. If there's an active roleset is
set, then it does show that information. On the other hand, if there's no active roles set
then it it requires admin privilege.
> We should fix the inconsistency and allow clients to see current roles without any admin

This message was sent by Atlassian JIRA

View raw message