sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sravya Tirukkovalur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SENTRY-339) Remove PrivilegeName column and constructPrivilegeName() function
Date Fri, 25 Jul 2014 20:52:38 GMT

    [ https://issues.apache.org/jira/browse/SENTRY-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074888#comment-14074888
] 

Sravya Tirukkovalur commented on SENTRY-339:
--------------------------------------------

Hi Arun, I see 4 failures with your patch: 

org.apache.sentry.tests.e2e.dbprovider.TestDatabaseProvider.testCornerCases
>>> org.apache.sentry.tests.e2e.dbprovider.TestDatabaseProvider.testShowPrivilegesByRoleOnObjectGivenDatabase
>>> org.apache.sentry.tests.e2e.dbprovider.TestDatabaseProvider.testShowPrivilegesByRoleObObjectGivenServer
>>> org.apache.sentry.tests.e2e.hive.TestPolicyImport.testImportPolicy

Can you please double check and repost the patch on both jira and RB? Thanks!

> Remove PrivilegeName column and constructPrivilegeName() function
> -----------------------------------------------------------------
>
>                 Key: SENTRY-339
>                 URL: https://issues.apache.org/jira/browse/SENTRY-339
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: db_policy_store
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: SENTRY-339.1.patch, SENTRY-339.2.patch, SENTRY-339.3.patch, SENTRY-339.4.patch,
SENTRY-339.4.patch, SENTRY-339.5.patch
>
>
> The {{privilegeName}} column in the Privilege table was initially created to enforce
uniqueness of Privileges with same server+db+table+uri+action. This can be done using composite
unique key constraint in the underlying db.
> It would also cleanup the Sentry Store codebase a bit.. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message