sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun Suresh (JIRA)" <>
Subject [jira] [Commented] (SENTRY-339) Remove PrivilegeName column and constructPrivilegeName() function
Date Thu, 17 Jul 2014 02:40:04 GMT


Arun Suresh commented on SENTRY-339:

Thank you for the feedback !!

bq. 1. I think we may need define a composite unique index key in jdo
So, I was actually more interested in imposing a unique constraint on a set of columns.. not
so much an index. But yeah, I agree the index with unique flag set to true should enforce
it.. will update the patch.

bq.  if action need set "" by default, need the grantorPrincipal set one..
When we were using {{privilegeName}} earlier, the grantorPrincipal was not a part of it. only
server, db, table, uri and action. I wanted to make just the minimun changes to the thrift
file to support this. Also, unique constraint for certains DBs require non-null column, which
is why we need server, db, table, uri and action to be non-null. We have no such requirement
for the grantorPrincipal column.

Hope this makes sense ?

> Remove PrivilegeName column and constructPrivilegeName() function
> -----------------------------------------------------------------
>                 Key: SENTRY-339
>                 URL:
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: db_policy_store
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: SENTRY-339.1.patch, SENTRY-339.2.patch
> The {{privilegeName}} column in the Privilege table was initially created to enforce
uniqueness of Privileges with same server+db+table+uri+action. This can be done using composite
unique key constraint in the underlying db.
> It would also cleanup the Sentry Store codebase a bit.. 

This message was sent by Atlassian JIRA

View raw message