sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gregory Chanan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SENTRY-362) When sentry integrate into solr, the create instance of backend needs configure parameters from solrAuthzConf not hadoopConf
Date Thu, 24 Jul 2014 18:58:38 GMT

    [ https://issues.apache.org/jira/browse/SENTRY-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073522#comment-14073522
] 

Gregory Chanan commented on SENTRY-362:
---------------------------------------

[~guoquan] good idea!

A couple of comments on the patch:
- Should we just use the authzConf as the basis for the configuration in getConf instead of
constructing a new one and adding the properties one-by-one?  I don't see why we need to keep
the original, non-modified one around.
- Can we give the authzConf a different parameter name from the stored variable i.e. something
like:
{code}
private AuthorizationProvider getAuthProvider(SolrAuthzConf solrAuthzConf) throws Exception
{
{code}?

> When sentry integrate into solr, the create instance of backend needs configure parameters
from solrAuthzConf not hadoopConf
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SENTRY-362
>                 URL: https://issues.apache.org/jira/browse/SENTRY-362
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: 1.3.0
>            Reporter: guoquanshen
>            Assignee: guoquanshen
>         Attachments: SENTRY-362.patch
>
>
> whatever Sentry Solr plugin integration with db store or file store, the create instance
of DBProviderBackend of FIleProviderBackend should get the configuration from sentry-site.xml
not hadoop configuration. The following code isn't correct:
> {code:title=SolrAuthzBinding.java}
>     Configuration conf = getConf();
>     providerBackend =(ProviderBackend) providerBackendConstructor.newInstance(new Object[]
{conf, resourceName});
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message