From commits-return-3134-apmail-sentry-commits-archive=sentry.apache.org@sentry.incubator.apache.org Wed Aug 20 09:02:51 2014 Return-Path: X-Original-To: apmail-sentry-commits-archive@minotaur.apache.org Delivered-To: apmail-sentry-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 42C0811C09 for ; Wed, 20 Aug 2014 09:02:51 +0000 (UTC) Received: (qmail 93481 invoked by uid 500); 20 Aug 2014 09:02:51 -0000 Delivered-To: apmail-sentry-commits-archive@sentry.apache.org Received: (qmail 93436 invoked by uid 500); 20 Aug 2014 09:02:51 -0000 Mailing-List: contact commits-help@sentry.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sentry.incubator.apache.org Delivered-To: mailing list commits@sentry.incubator.apache.org Received: (qmail 93425 invoked by uid 99); 20 Aug 2014 09:02:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Aug 2014 09:02:51 +0000 X-ASF-Spam-Status: No, hits=-2000.7 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 20 Aug 2014 09:02:29 +0000 Received: (qmail 93025 invoked by uid 99); 20 Aug 2014 09:02:26 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Aug 2014 09:02:26 +0000 Date: Wed, 20 Aug 2014 09:02:26 +0000 (UTC) From: "guoquanshen (JIRA)" To: commits@sentry.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (SENTRY-396) The Thrift multiplexedProcessor registers mutil processor failed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SENTRY-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] guoquanshen updated SENTRY-396: ------------------------------- Attachment: SENTRY-396.patch > The Thrift multiplexedProcessor registers mutil processor failed > ---------------------------------------------------------------- > > Key: SENTRY-396 > URL: https://issues.apache.org/jira/browse/SENTRY-396 > Project: Sentry > Issue Type: Bug > Affects Versions: 1.4.0 > Reporter: guoquanshen > Assignee: guoquanshen > Fix For: 1.5.0 > > Attachments: SENTRY-396.patch > > > The sentry service uses multiplexedProcessor to register multi processor, but the logic isn't correct in my opinion. It use processFactory to register and the source code as following: > {code}TMultiplexedProcessor processor = new TMultiplexedProcessor(); > boolean registeredProcessor = false; > for (String processorFactory : processorFactories){ > ProcessorFactory factory = (ProcessorFactory) #create factory instance with processorFactory name > registeredProcessor = registeredProcessor || factory.register(processor); > }{code} > If the first factory register successfully, registeredProcessor will become true then the following factories don't get the chance to register -- This message was sent by Atlassian JIRA (v6.2#6252)