sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lenni Kuff (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SENTRY-511) Do not start timers when SentryMetrics is disabled
Date Thu, 30 Oct 2014 05:07:34 GMT

    [ https://issues.apache.org/jira/browse/SENTRY-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14189649#comment-14189649
] 

Lenni Kuff commented on SENTRY-511:
-----------------------------------

Question - I understand disabling all reporting of metrics, but why would we want to disable
the actual internal metric collection? Does it fail if there are no reporters registered?
IMO, we should also internally collect the metrics since it is very lightweight and allow
disabling reporting. 

> Do not start timers when SentryMetrics is disabled
> --------------------------------------------------
>
>                 Key: SENTRY-511
>                 URL: https://issues.apache.org/jira/browse/SENTRY-511
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Sravya Tirukkovalur
>            Assignee: Sravya Tirukkovalur
>             Fix For: 1.5.0
>
>         Attachments: SENTRY-511.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message