sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lenni Kuff (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SENTRY-511) Do not start timers when SentryMetrics is disabled
Date Thu, 30 Oct 2014 18:34:33 GMT

    [ https://issues.apache.org/jira/browse/SENTRY-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190569#comment-14190569
] 

Lenni Kuff commented on SENTRY-511:
-----------------------------------

I agree, there is no use to collecting metrics if we are not exposing them. The goal is to
avoid all the checks if metric reporting is enabled. It adds more code and we are surely going
to miss the check at some point leading to a failure. If we just always keep the metrics enabled
and then allow configuration of how they are reported it keeps things a bit simpler.

> Do not start timers when SentryMetrics is disabled
> --------------------------------------------------
>
>                 Key: SENTRY-511
>                 URL: https://issues.apache.org/jira/browse/SENTRY-511
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Sravya Tirukkovalur
>            Assignee: Sravya Tirukkovalur
>             Fix For: 1.5.0
>
>         Attachments: SENTRY-511.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message