sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dapeng Sun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SENTRY-513) Sentry web service may not be stopped completely
Date Thu, 06 Nov 2014 01:20:35 GMT

    [ https://issues.apache.org/jira/browse/SENTRY-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14199547#comment-14199547
] 

Dapeng Sun commented on SENTRY-513:
-----------------------------------

Thank Sravya for your review and commit.

> Sentry web service may not be stopped completely
> ------------------------------------------------
>
>                 Key: SENTRY-513
>                 URL: https://issues.apache.org/jira/browse/SENTRY-513
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Dapeng Sun
>            Assignee: Dapeng Sun
>             Fix For: 1.5.0
>
>         Attachments: SENTRY-513.002.patch, SENTRY-513.003.patch, SENTRY-513.patch
>
>
> {code}
>  public synchronized void stop() throws Exception{
>     if (status == Status.NOT_STARTED) {
>       return;
>     }
>     LOGGER.info("Attempting to stop...");
>     if (thriftServer.isServing()) {
>       thriftServer.stop(); // XXX If got exception here, the code after it will never
be executed. 
>     }
>     thriftServer = null;
>     stopSentryWebServer();
>     status = Status.NOT_STARTED;
>     LOGGER.info("Stopped...");
>   }
> {code} 
> if {{thriftServer}} got an exception when do stop, the method {{stopSentryWebServer()}}
will be passed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message