sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun Suresh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SENTRY-529) [Unit Test]org.apache.sentry.tests.e2e.hdfs.TestHDFSIntegrationtestEnd2End test fails after SENTRY-74
Date Wed, 19 Nov 2014 17:50:33 GMT

    [ https://issues.apache.org/jira/browse/SENTRY-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218224#comment-14218224
] 

Arun Suresh commented on SENTRY-529:
------------------------------------

I was just looking at the patch..

Doing it like the way in the patch should not cause problems but you might be wasting cycles
iterating over the set :
The SentryHDFSPlugin should not really care about the column privileges. I presume the {{set<TSentryPrivilege>}}
that will be optionally set in the Grant/Revoke request would be for multiple columns.. only
the Table level privilege need to be sent to sent to Plugin.. in which case, I guess we need
to iterate over the set and pick only the table level privileges and send it to the {{permsUpdate}}

> [Unit Test]org.apache.sentry.tests.e2e.hdfs.TestHDFSIntegrationtestEnd2End test fails
after SENTRY-74
> -----------------------------------------------------------------------------------------------------
>
>                 Key: SENTRY-529
>                 URL: https://issues.apache.org/jira/browse/SENTRY-529
>             Project: Sentry
>          Issue Type: Bug
>            Reporter: Dapeng Sun
>            Assignee: Dapeng Sun
>            Priority: Blocker
>         Attachments: SENTRY-529.002.patch, SENTRY-529.patch
>
>
> {{SentryHDFSPlugin}} is using {{TSentryPrivilege}} in {{TAlterSentryRoleRevokePrivilegeRequest}}
and  {{TAlterSentryRoleGrantPrivilegeRequest}} , after SENTRY-74, it have changed to {{Set<TSentryPrivilege>}},adjust
{{SentryHDFSPlugin}} for the change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message