sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Ma (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SENTRY-792) Throw underlying exception if SentryService start fails
Date Mon, 13 Jul 2015 01:08:05 GMT

    [ https://issues.apache.org/jira/browse/SENTRY-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624093#comment-14624093
] 

Colin Ma commented on SENTRY-792:
---------------------------------

+1, LGTM

> Throw underlying exception if SentryService start fails
> -------------------------------------------------------
>
>                 Key: SENTRY-792
>                 URL: https://issues.apache.org/jira/browse/SENTRY-792
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Sravya Tirukkovalur
>            Assignee: Sravya Tirukkovalur
>            Priority: Critical
>             Fix For: 1.6.0
>
>         Attachments: SENTRY-792.patch
>
>
> waitForShutDown() in SentryService is named wrongly. It in fact just waits for the service
thread to complete startup. And it just logs a debug message if things fail.
> LOGGER.debug("Error during the shutdown", e);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message