sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dapeng Sun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SENTRY-841) Revoke on SERVER scope breaks Client API, allows any string to be passed in
Date Sun, 06 Sep 2015 01:28:46 GMT

    [ https://issues.apache.org/jira/browse/SENTRY-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14732153#comment-14732153
] 

Dapeng Sun commented on SENTRY-841:
-----------------------------------

+1. I will commit to trunk and branch-1.6.0.

[~Ryan P], Thank you for your contribution.

Also thank [~colin_mjj] for your review.

> Revoke on SERVER scope breaks Client API, allows any string to be passed in
> ---------------------------------------------------------------------------
>
>                 Key: SENTRY-841
>                 URL: https://issues.apache.org/jira/browse/SENTRY-841
>             Project: Sentry
>          Issue Type: Bug
>          Components: Service
>    Affects Versions: 1.6.0
>            Reporter: Lenni Kuff
>            Assignee: Ryan P
>         Attachments: SENTRY-841.patch, SENTRY-841.patch, SENTRY-841.patch
>
>
> Revoke on server scope change the Java API in an incompatible way (added a new parameter).
We need to fix the client API to have an overload for revoke which defaults to "ALL" privileges
if nothing is specified. 
> Additionally, it looks like any string can be passed in for the "action" field of the
new API. We should validate that the action is valid - "SELECT", "INSERT", or "ALL". 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message