sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lenni Kuff (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SENTRY-1002) PathsUpdate.parsePath(path) will throw an NPE when parsing relative paths
Date Mon, 11 Jan 2016 17:18:40 GMT

    [ https://issues.apache.org/jira/browse/SENTRY-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092305#comment-15092305
] 

Lenni Kuff commented on SENTRY-1002:
------------------------------------

Two comments:
# When I think of "relative" paths I think of a path that does not have a root. For example
'path/to/file' vs '/path/to/file'. In this case we are really looking at paths that do not
have a schema/authority.
# It looks like you are returning "null" in the case the path does not have a scheme. Is this
desired? 

> PathsUpdate.parsePath(path) will throw an NPE when parsing relative paths
> -------------------------------------------------------------------------
>
>                 Key: SENTRY-1002
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1002
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 1.6.0
>            Reporter: Ryan P
>            Assignee: Ryan P
>         Attachments: SENTRY-1002.patch, SENTRY-1002.patch
>
>
> There a few edge cases where Paths update may be passed a path which lacks a URI Scheme.

> i.e 
> /user/hive/warehouse 
> In this situation PathsUpdate will throw an uncaught NPE at the Precondition check. 
> Since we only support HDFS anyway I suggest we silently ignore these relative paths.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message