From commits-return-11350-apmail-sentry-commits-archive=sentry.apache.org@sentry.apache.org Fri Jun 17 17:42:28 2016 Return-Path: X-Original-To: apmail-sentry-commits-archive@minotaur.apache.org Delivered-To: apmail-sentry-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7AEB4193B3 for ; Fri, 17 Jun 2016 17:42:28 +0000 (UTC) Received: (qmail 95536 invoked by uid 500); 17 Jun 2016 17:42:28 -0000 Delivered-To: apmail-sentry-commits-archive@sentry.apache.org Received: (qmail 95492 invoked by uid 500); 17 Jun 2016 17:42:28 -0000 Mailing-List: contact commits-help@sentry.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sentry.apache.org Delivered-To: mailing list commits@sentry.apache.org Received: (qmail 95483 invoked by uid 99); 17 Jun 2016 17:42:28 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jun 2016 17:42:28 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 3B1F6E049D; Fri, 17 Jun 2016 17:42:28 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: anneyu@apache.org To: commits@sentry.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: sentry git commit: SENTRY-1336: Fix PMD violation in testSentryServiceGauges (Rahul Sharma, reviewed by Anne Yu) Date: Fri, 17 Jun 2016 17:42:28 +0000 (UTC) Repository: sentry Updated Branches: refs/heads/sentry-ha-redesign 81990992b -> 08b2212bb SENTRY-1336: Fix PMD violation in testSentryServiceGauges (Rahul Sharma, reviewed by Anne Yu) Project: http://git-wip-us.apache.org/repos/asf/sentry/repo Commit: http://git-wip-us.apache.org/repos/asf/sentry/commit/08b2212b Tree: http://git-wip-us.apache.org/repos/asf/sentry/tree/08b2212b Diff: http://git-wip-us.apache.org/repos/asf/sentry/diff/08b2212b Branch: refs/heads/sentry-ha-redesign Commit: 08b2212bbce3a9e672734ceeed01832fd3fdbd6e Parents: 8199099 Author: Anne Yu Authored: Fri Jun 17 10:58:43 2016 -0700 Committer: Anne Yu Committed: Fri Jun 17 10:58:43 2016 -0700 ---------------------------------------------------------------------- .../provider/db/service/thrift/TestSentryServiceMetrics.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/sentry/blob/08b2212b/sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceMetrics.java ---------------------------------------------------------------------- diff --git a/sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceMetrics.java b/sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceMetrics.java index 441a108..3fff450 100644 --- a/sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceMetrics.java +++ b/sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceMetrics.java @@ -44,8 +44,8 @@ public class TestSentryServiceMetrics extends SentryServiceIntegrationBase { //More Cases to be added once Sentry HA is implemented //Check for gauges with the server handle. - Assert.assertEquals(new Boolean(false),server.getIsHAGauge().getValue()); - Assert.assertEquals(new Boolean(true),server.getIsActiveGauge().getValue()); + Assert.assertEquals(Boolean.FALSE,server.getIsHAGauge().getValue()); + Assert.assertEquals(Boolean.TRUE,server.getIsActiveGauge().getValue()); } //Overriding this method as the client handle does not exist.