sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sp...@apache.org
Subject sentry git commit: Revert "SENTRY-2017: Fix Sentry e2e tests to use SentryMetastorePostEventListenerNotificationLog."
Date Fri, 03 Nov 2017 14:54:09 GMT
Repository: sentry
Updated Branches:
  refs/heads/master 64476a747 -> 0235d5959


Revert "SENTRY-2017: Fix Sentry e2e tests to use SentryMetastorePostEventListenerNotificationLog."

It is causing some unit tests to fail.

This reverts commit 99efc7fc960d5680fc7605400e0375a7883bae37.


Project: http://git-wip-us.apache.org/repos/asf/sentry/repo
Commit: http://git-wip-us.apache.org/repos/asf/sentry/commit/0235d595
Tree: http://git-wip-us.apache.org/repos/asf/sentry/tree/0235d595
Diff: http://git-wip-us.apache.org/repos/asf/sentry/diff/0235d595

Branch: refs/heads/master
Commit: 0235d595930ecdd12e48da1b7e090f8eb801ef2a
Parents: 64476a7
Author: Sergio Pena <sergio.pena@cloudera.com>
Authored: Fri Nov 3 09:49:11 2017 -0500
Committer: Sergio Pena <sergio.pena@cloudera.com>
Committed: Fri Nov 3 09:49:11 2017 -0500

----------------------------------------------------------------------
 .../tests/e2e/hive/AbstractTestWithStaticConfiguration.java   | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/sentry/blob/0235d595/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java
----------------------------------------------------------------------
diff --git a/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java
b/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java
index 630bc68..5fb4659 100644
--- a/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java
+++ b/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java
@@ -128,6 +128,7 @@ public abstract class AbstractTestWithStaticConfiguration extends RulesForE2ETes
   protected static final String SERVER_HOST = "localhost";
   private static final String EXTERNAL_SENTRY_SERVICE = "sentry.e2etest.external.sentry";
   protected static final String EXTERNAL_HIVE_LIB = "sentry.e2etest.hive.lib";
+  private static final String ENABLE_NOTIFICATION_LOG = "sentry.e2etest.enable.notification.log";
 
   protected static boolean policyOnHdfs = false;
   protected static boolean defaultFSOnHdfs = false;
@@ -151,7 +152,7 @@ public abstract class AbstractTestWithStaticConfiguration extends RulesForE2ETes
   protected static Map<String, String> properties;
   protected static SentrySrv sentryServer;
   protected static Configuration sentryConf;
-  protected static boolean enableNotificationLog = true;
+  protected static boolean enableNotificationLog = false;
   protected static Context context;
   protected final String semanticException = "SemanticException No valid privileges";
 
@@ -281,6 +282,10 @@ public abstract class AbstractTestWithStaticConfiguration extends RulesForE2ETes
       policyURI = policyFileLocation.getPath();
     }
 
+    if ("true".equalsIgnoreCase(System.getProperty(ENABLE_NOTIFICATION_LOG, "false"))) {
+      enableNotificationLog = true;
+    }
+
     if (enableHiveConcurrency) {
       properties.put(HiveConf.ConfVars.HIVE_SUPPORT_CONCURRENCY.varname, "true");
       properties.put(HiveConf.ConfVars.HIVE_TXN_MANAGER.varname,


Mime
View raw message