shiro-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lhazlew...@apache.org
Subject svn commit: r806298 - /incubator/shiro/trunk/core/src/main/java/org/apache/shiro/config/ReflectionBuilder.java
Date Thu, 20 Aug 2009 18:43:25 GMT
Author: lhazlewood
Date: Thu Aug 20 18:43:25 2009
New Revision: 806298

URL: http://svn.apache.org/viewvc?rev=806298&view=rev
Log:
SHIRO-85 - fixed by using LinkedHashMap instead of HashMap

Modified:
    incubator/shiro/trunk/core/src/main/java/org/apache/shiro/config/ReflectionBuilder.java

Modified: incubator/shiro/trunk/core/src/main/java/org/apache/shiro/config/ReflectionBuilder.java
URL: http://svn.apache.org/viewvc/incubator/shiro/trunk/core/src/main/java/org/apache/shiro/config/ReflectionBuilder.java?rev=806298&r1=806297&r2=806298&view=diff
==============================================================================
--- incubator/shiro/trunk/core/src/main/java/org/apache/shiro/config/ReflectionBuilder.java
(original)
+++ incubator/shiro/trunk/core/src/main/java/org/apache/shiro/config/ReflectionBuilder.java
Thu Aug 20 18:43:25 2009
@@ -18,18 +18,16 @@
  */
 package org.apache.shiro.config;
 
-import java.beans.PropertyDescriptor;
-import java.util.HashMap;
-import java.util.LinkedHashMap;
-import java.util.Map;
-
 import org.apache.commons.beanutils.BeanUtils;
 import org.apache.commons.beanutils.PropertyUtils;
+import org.apache.shiro.util.ClassUtils;
+import org.apache.shiro.util.Nameable;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import org.apache.shiro.util.ClassUtils;
-import org.apache.shiro.util.Nameable;
+import java.beans.PropertyDescriptor;
+import java.util.LinkedHashMap;
+import java.util.Map;
 
 
 /**
@@ -76,8 +74,11 @@
 
             // Separate key value pairs into object declarations and property assignment
             // so that all objects can be created up front
-            Map<String, String> instanceMap = new HashMap<String, String>();
-            Map<String, String> propertyMap = new HashMap<String, String>();
+
+            //https://issues.apache.org/jira/browse/SHIRO-85 - need to use LinkedHashMaps
here:
+            Map<String, String> instanceMap = new LinkedHashMap<String, String>();
+            Map<String, String> propertyMap = new LinkedHashMap<String, String>();
+
             for (Map.Entry<String, String> entry : kvPairs.entrySet()) {
                 if (entry.getKey().indexOf('.') < 0 || entry.getKey().endsWith(".class"))
{
                     instanceMap.put(entry.getKey(), entry.getValue());



Mime
View raw message