spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] incubator-spark pull request: [WIP] SPARK-1058, Fix Style Errors a...
Date Sat, 08 Feb 2014 19:57:24 GMT
Github user pwendell commented on the pull request:

    https://github.com/apache/incubator-spark/pull/557#issuecomment-34554122
  
    Hey @ScrapCodes I noticed the size of indent is inconsistent. The rule is to always use
2 spaces. If you are breaking initialization of a code block (e.g. a function signature) then
it's okay to use 4 spaces to distinguish it from the body. I think scala is silent on this
exception but it's the convention we usually use.
    
    If you could go through and address those I'm happy to merge an intermediate clean-up
to avoid conflicts.


Mime
View raw message