spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] incubator-spark pull request: Support MiMa for reporting binary co...
Date Fri, 14 Feb 2014 23:43:28 GMT
Github user pwendell commented on the pull request:

    https://github.com/apache/incubator-spark/pull/585#issuecomment-35139456
  
    Hey @ScrapCodes - this is a great start! To give some background, we actually want to
use this and reject pull requests that cause Mima errors. That means we need to configure
it so normal development won't return errors by having appropriate excludes. I just ran it
and many of the errors seem like false positives - for instance they are in the "deploy" package.
The Mima code isn't super well documented, but I believe the offer excludes for these things
- so it would be great if you could check these out and try to put in the appropriate excludes
to distinguish false positives from actual issues.
    



Mime
View raw message