spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] incubator-spark pull request: Enable SparkContext.addJars() to loa...
Date Tue, 18 Feb 2014 05:12:15 GMT
Github user pwendell commented on the pull request:

    https://github.com/apache/incubator-spark/pull/299#discussion_r9812781
  
    Mind formatting this to meet the style guide:
    ```
    private[spark] val classLoader =
        if (conf.getBoolean("spark.driver.add-dynamic-jars", false)) {
          val loader = new SparkURLClassLoader(Array.empty[URL], this.getClass.getClassLoader)
          Thread.currentThread.setContextClassLoader(loader)
          Some(loader)
        } else {
          None
        }
    ```
    The only hard requirement is adding brackets and linebreaks around the `None`. The linebreak
at the beginning I don't think we require... that one's up to you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

Mime
View raw message