spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aarondav <...@git.apache.org>
Subject [GitHub] incubator-spark pull request: Migrate Java code to Scala or move i...
Date Wed, 19 Feb 2014 01:00:57 GMT
Github user aarondav commented on the pull request:

    https://github.com/apache/incubator-spark/pull/605#discussion_r9850119
  
    The exact same confusion led me to centralize and document this :)
    
    Just as a stylistic thing, I think we can put these on one line (that's the ideal for
single-line functions without braces). Also the [R] is inferred from the return type, so this
is sufficient:
    `def returnType(): ClassTag[R] = JavaSparkContext.fakeClassTag`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

Mime
View raw message