spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] incubator-spark pull request: [SPARK-1094] Support MiMa for report...
Date Thu, 20 Feb 2014 00:02:38 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/incubator-spark/pull/585#discussion_r9889925
  
    --- Diff: project/MimaBuild.scala ---
    @@ -0,0 +1,105 @@
    +import com.typesafe.tools.mima.plugin.MimaKeys.{binaryIssueFilters, previousArtifact}
    +import com.typesafe.tools.mima.plugin.MimaPlugin.mimaDefaultSettings
    +
    +object MimaBuild {
    +
    +  val ignoredABIProblems = {
    +    import com.typesafe.tools.mima.core._
    +    import com.typesafe.tools.mima.core.ProblemFilters._
    +    /**
    +     * A: Detections are semi private or likely to become semi private at some point.
    +     */
    +    Seq(exclude[MissingClassProblem]("org.apache.spark.util.XORShiftRandom"),
    +      exclude[MissingClassProblem]("org.apache.spark.util.XORShiftRandom$"),
    +      exclude[MissingMethodProblem]("org.apache.spark.util.Utils.cloneWritables"),
    +      // Scheduler is not considered a public API.
    +      excludePackage("org.apache.spark.deploy"),
    +      // Was made private in 1.0
    --- End diff --
    
    Hey @ScrapCodes - now that we have a better understand of what is going on, let's do the
following. For things where the class is package private let's exclude the entire class and
then explain why. So here it could be:
    
        // The below classes are package private but not ignored correctly by MIMA
        exclude[MissingMethodProblem]("org.apache.spark.util.collection.ExternalAppendOnlyMap")
    
      


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

Mime
View raw message