spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] incubator-spark pull request: Fix ExternalMap on case of key's has...
Date Thu, 20 Feb 2014 21:40:21 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/incubator-spark/pull/612#discussion_r9925806
  
    --- Diff: core/src/test/scala/org/apache/spark/util/collection/ExternalAppendOnlyMapSuite.scala
---
    @@ -83,6 +83,28 @@ class ExternalAppendOnlyMapSuite extends FunSuite with BeforeAndAfter
with Local
           (3, Set[Int](30))))
       }
     
    +  test("insert with collision on hashCode Int.MaxValue") {
    --- End diff --
    
    I would rename this "spilling with..." instead of "insert with...". More details explained
below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

Mime
View raw message