spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ScrapCodes <...@git.apache.org>
Subject [GitHub] incubator-spark pull request: Deprecated and added a few java api ...
Date Fri, 21 Feb 2014 03:44:26 GMT
Github user ScrapCodes commented on a diff in the pull request:

    https://github.com/apache/incubator-spark/pull/402#discussion_r9935572
  
    --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDDLike.scala ---
    @@ -73,7 +74,7 @@ trait JavaRDDLike[T, This <: JavaRDDLike[T, This]] extends Serializable
{
        * of the original partition.
        */
       def mapPartitionsWithIndex[R: ClassTag](
    -      f: JFunction2[Int, java.util.Iterator[T], java.util.Iterator[R]],
    +      f: JFunction2[Integer, java.util.Iterator[T], java.util.Iterator[R]],
    --- End diff --
    
    Well I think there was a context to that comment, Earlier right above that
    we were importing java.lang.Integer and then using it. He asked me to
    remove and make it java.lang.Integer, but later I discovered import was not
    necessary. But if you think having that specified explicitly is good, it
    can be done in a moment ?
    
    
    On Fri, Feb 21, 2014 at 7:26 AM, Patrick Wendell
    <notifications@github.com>wrote:
    
    > In core/src/main/scala/org/apache/spark/api/java/JavaRDDLike.scala:
    >
    > > @@ -73,7 +74,7 @@ trait JavaRDDLike[T, This <: JavaRDDLike[T, This]] extends
Serializable {
    > >     * of the original partition.
    > >     */
    > >    def mapPartitionsWithIndex[R: ClassTag](
    > > -      f: JFunction2[Int, java.util.Iterator[T], java.util.Iterator[R]],
    > > +      f: JFunction2[Integer, java.util.Iterator[T], java.util.Iterator[R]],
    >
    > @ScrapCodes <https://github.com/ScrapCodes> I think @rxin<https://github.com/rxin>is
suggesting that you should actually write
    > java.lang.Integer to make it more explicit.
    >
    > --
    > Reply to this email directly or view it on GitHub<https://github.com/apache/incubator-spark/pull/402/files#r9934007>
    > .
    >
    
    
    
    -- 
    Prashant


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

Mime
View raw message