spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aarondav <...@git.apache.org>
Subject [GitHub] incubator-spark pull request: SPARK-1084. Fix most build warnings
Date Sun, 23 Feb 2014 00:38:29 GMT
Github user aarondav commented on the pull request:

    https://github.com/apache/incubator-spark/pull/586#issuecomment-35820063
  
    Do you think it would be possible to separate this into two patches, one for the code
warnings and one for the build issues? Code warnings are relatively easy to clean up without
issue (and thus merge quickly), but we need to be very careful with dependencies; i.e., we
need to go in and confirm that every change is not adding or removing actual dependencies.
    
    The dependencies changes can also be incorporated into a more general "clean up the build
file" type patch, since I noticed that there may be other issues, like spark streaming including
commons-io when it is already included in sharedSettings.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

Mime
View raw message