spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aarondav <...@git.apache.org>
Subject [GitHub] incubator-spark pull request: SPARK-1063 Add .sortBy(f) method on ...
Date Sun, 23 Feb 2014 00:43:24 GMT
Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/incubator-spark/pull/508#discussion_r9973811
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
    @@ -394,6 +394,17 @@ abstract class RDD[T: ClassTag](
       def ++(other: RDD[T]): RDD[T] = this.union(other)
     
       /**
    +   * Return this RDD sorted by the given key function.
    +   */
    +  def sortBy[K: Ordering: ClassTag](
    +      f: (T) ⇒ K,
    +      ascending: Boolean = true,
    --- End diff --
    
    It's nice that you've added parameters for ascending and numPartitions, but nicer still
would be to use them :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

Mime
View raw message