spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] incubator-spark pull request: SPARK-1084. Fix most build warnings
Date Sun, 23 Feb 2014 09:46:20 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/incubator-spark/pull/586#discussion_r9975099
  
    --- Diff: project/SparkBuild.scala ---
    @@ -340,7 +336,8 @@ object SparkBuild extends Build {
       def streamingSettings = sharedSettings ++ Seq(
         name := "spark-streaming",
         libraryDependencies ++= Seq(
    -      "commons-io" % "commons-io" % "2.4"
    +      "commons-io" % "commons-io" % "2.4",
    +      "org.codehaus.jackson" % "jackson-mapper-asl" % "1.9.11"
    --- End diff --
    
    This was just making the sbt build consistent with Maven. But yeah on second glance it
does look like Streaming doesn't even use Jackson! This can be removed in both places. Commons
IO is used. I'll wait on your comment about splitting into a PR to move forward with fixes
like this in this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

Mime
View raw message