spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From CodingCat <...@git.apache.org>
Subject [GitHub] incubator-spark pull request: For outputformats that are Configura...
Date Mon, 24 Feb 2014 01:38:19 GMT
Github user CodingCat commented on a diff in the pull request:

    https://github.com/apache/incubator-spark/pull/638#discussion_r9979453
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala ---
    @@ -617,6 +617,10 @@ class PairRDDFunctions[K: ClassTag, V: ClassTag](self: RDD[(K, V)])
             attemptNumber)
           val hadoopContext = newTaskAttemptContext(wrappedConf.value, attemptId)
           val format = outputFormatClass.newInstance
    +      format match {
    +        case c:Configurable => c.setConf(wrappedConf.value)
    --- End diff --
    
    do we need some comments here to indicate that this line is to support a special case
in HBase?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

Mime
View raw message