spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From CodingCat <...@git.apache.org>
Subject [GitHub] incubator-spark pull request: [SPARK-1041] remove dead code in sta...
Date Wed, 12 Feb 2014 18:25:58 GMT
GitHub user CodingCat opened a pull request:

    https://github.com/apache/incubator-spark/pull/588

    [SPARK-1041] remove dead code in start script, remind user to set that in spark-env.sh

    the lines in start-master.sh and start-slave.sh no longer work
    
    in ec2, the host name has changed, e.g.
    
    ubuntu@ip-172-31-36-93:~$ hostname
    ip-172-31-36-93
    
    also, the URL to fetch public DNS name also changed, e.g.
    
    ubuntu@ip-172-31-36-93:~$ wget -q -O - http://instance-data.ec2.internal/latest/meta-data/public-hostname
    ubuntu@ip-172-31-36-93:~$  (returns nothing)
    
    since we have spark-ec2 project, we don't need to have such ec2-specific lines here, instead,
user only need to set in spark-env.sh
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-spark deadcode_in_sbin

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-spark/pull/588.patch

----
commit e4236e0c717e1ce7b6f91a83ce4c0cb7a4ae8046
Author: CodingCat <zhunansjtu@gmail.com>
Date:   2014-02-12T18:24:34Z

    remove dead code in start script, remind user set that in spark-env.sh

----


Mime
View raw message