spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...
Date Sat, 01 Mar 2014 04:16:26 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/42#discussion_r10189124
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala ---
    @@ -17,21 +17,23 @@
     
     package org.apache.spark.executor
     
    +import org.apache.spark.storage.{BlockId, BlockStatus}
    +
     class TaskMetrics extends Serializable {
       /**
    -   * Host's name the task runs on 
    +   * Host's name the task runs on
        */
       var hostname: String = _
     
       /**
        * Time taken on the executor to deserialize this task
        */
    -  var executorDeserializeTime: Int = _
    +  var executorDeserializeTime: Long = _
    --- End diff --
    
    It's more consistent with the rest of the code - variables denoting time and number of
bytes in other places use Long. Also, the way these variables are set is through System.currentTimeMillis()
anyway, and then arbitrarily cast to Int.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message