spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From witgo <...@git.apache.org>
Subject [GitHub] spark pull request: fix #SPARK-1149 Bad partitioners can cause Spa...
Date Sun, 02 Mar 2014 06:17:51 GMT
Github user witgo commented on a diff in the pull request:

    https://github.com/apache/spark/pull/44#discussion_r10194313
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -847,6 +847,8 @@ class SparkContext(
           partitions: Seq[Int],
           allowLocal: Boolean,
           resultHandler: (Int, U) => Unit) {
    +    val rddPartitions = rdd.partitions.map(_.index)
    +    require(partitions.forall(rddPartitions.contains(_)), "partition index out of range")
    --- End diff --
    
    Do not understand what you mean.
    Caused by improper design Partitioner partition index out of range.
    
        val partitioner = new Partitioner {
         override def numPartitions: Int = 2
         override def getPartition(key: Any): Int = key.hashCode() % 2
        }
    
    `partitioner.getPartition(-1)` result  -1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message