spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1126. spark-app preliminary
Date Thu, 06 Mar 2014 03:52:14 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/86#discussion_r10330832
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala ---
    @@ -0,0 +1,178 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.deploy
    +
    +import java.io.BufferedReader
    +import java.io.InputStream
    +import java.io.InputStreamReader
    +import java.io.PrintStream
    +
    +import scala.collection.mutable.HashMap
    +import scala.collection.mutable.Map
    +import scala.collection.mutable.ArrayBuffer
    +import scala.collection.JavaConverters._
    +
    +object SparkApp {
    +  val CLIENT = 1
    +  val CLUSTER = 2
    +  val YARN = 1
    +  val STANDALONE = 2
    +  val MESOS = 4
    +  val LOCAL = 8
    +  val ALL_CLUSTER_MGRS = YARN | STANDALONE | MESOS | LOCAL
    +
    +  var clusterManager: Int = LOCAL
    +
    +  def main(args: Array[String]) {
    +    println("args: " + args.toList)
    +    val appArgs = new SparkAppArguments(args)
    +
    +    if (appArgs.master != null) {
    +      if (appArgs.master.startsWith("yarn")) {
    --- End diff --
    
    Hey one thing I realize while looking it this. I'm not sure it says anywhere in any docs
that you are supposed to set the master to `yarn-standalone` when initializing a SparkContext
for use on yarn. I realize this is unrelated to your PR, but it would be great if you could
add that to the YARN documentation /cc @tgraves (maybe I missed it?). Also it's a little confusing
calling it `yarn-standalone` - it might make sense to rename this to `yarn-cluster` and `yarn-client`
since there is a name collision with "The standalone cluster manager".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message