spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1132] Persisting Web UI through refacto...
Date Thu, 06 Mar 2014 21:28:16 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/42#discussion_r10361732
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
    @@ -30,16 +32,23 @@ import org.apache.spark.scheduler._
      * class, since the UI thread and the DAGScheduler event loop may otherwise
      * be reading/updating the internal data structures concurrently.
      */
    -private[spark] class JobProgressListener(val sc: SparkContext) extends SparkListener
{
    +private[ui] class JobProgressListener(sc: SparkContext, live: Boolean)
    +  extends StorageStatusSparkListener {
    +
    +  import JobProgressListener._
    +
       // How many stages to remember
    -  val RETAINED_STAGES = sc.conf.getInt("spark.ui.retainedStages", 1000)
    -  val DEFAULT_POOL_NAME = "default"
    +  val retainedStages = if (live) {
    +    sc.conf.getInt("spark.ui.retainedStages", DEFAULT_RETAINED_STAGES)
    --- End diff --
    
    Why not let this be configurable for re-created UIs too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message