spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1132] Persisting Web UI through refacto...
Date Mon, 10 Mar 2014 23:21:46 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/42#discussion_r10455635
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/UISparkListener.scala ---
    @@ -0,0 +1,123 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.ui
    +
    +import scala.collection.mutable
    +
    +import org.apache.spark.scheduler._
    +import org.apache.spark.storage._
    +
    +private[ui] trait UISparkListener extends SparkListener
    +
    +/**
    + * A SparkListener that maintains executor storage status
    + */
    +private[ui] class StorageStatusSparkListener extends UISparkListener {
    --- End diff --
    
    I believe the UI is the only usage of a SparkListener that builds storage status from
events. If the SparkContext is alive, then you can just ask the driver for this information.
So I think it should live in the UI.
    
    As for whether to extend this class... I need to give more thought to it. One reason why
it's not a good idea is because we end up maintaining two separate storage status lists with
exactly the same information (because both ExecutorsUI and BlockManagerUI use this). The alternative
is to keep it in SparkUI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message