spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <>
Subject [GitHub] spark pull request: [SPARK-1132] Persisting Web UI through refacto...
Date Tue, 11 Mar 2014 00:46:13 GMT
Github user andrewor14 commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
    @@ -30,16 +32,23 @@ import org.apache.spark.scheduler._
      * class, since the UI thread and the DAGScheduler event loop may otherwise
      * be reading/updating the internal data structures concurrently.
    --- End diff --
    Not sure... though it appears that you wrote this comment a while back. You could imagine
a case in which the user refreshes the browser, which reads from these data structures, while
the SparkListenerBus thread is updating them through an event, leading to inconsistent state
reported on the UI.
    However, other UI listeners do not synchronize on their data structures, and I haven't
observed a concurrency issue.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message