spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1132] Persisting Web UI through refacto...
Date Tue, 11 Mar 2014 01:05:49 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/42#discussion_r10458236
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
    @@ -30,16 +32,23 @@ import org.apache.spark.scheduler._
      * class, since the UI thread and the DAGScheduler event loop may otherwise
      * be reading/updating the internal data structures concurrently.
    --- End diff --
    
    Ok I think what I was getting at here was two things:
    
    1) Could you change this comment to say "EventBus thread" rather than "DAGScheduler event
loop", since now the listener stuff is totally separate from the dag scheduler?
    
    2) The issue here is that the UI can be loading a page (and accessing these data structures)
at the same time that the EventBus loop is calling the various listener methods (this was
causing issues in the past; when I fixed that, I wrote this comment).  So, I think that the
new methods that you added need to be synchronized.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message